2018-10-19 18:36:22 (edited by kianoosh 2018-10-19 18:37:30)

Hello. I have coded an fps game in python3 with a bunch of nice formulas for those who are beginner to python game development and want to start their gerny on it. Feel free to code your games using this engine-like thing! Read the readme for more details.
I hope more people leave bgt for python, Resulting of more high quality audio games for all of us in the future!
https://github.com/kianoosh-shakeri/python-fps
Have a nice time!

---
Co-founder of Sonorous Arts.
Check out Sonorous Arts on github: https://github.com/sonorous-arts/
my Discord: kianoosh.shakeri2#2988

2018-10-19 18:57:00

Thanks a lot kianoosh. Most appreciated. big_smile

2018-10-19 19:53:41

So that's what you do instead of coding firefight? lol.

2018-10-19 21:07:37 (edited by kianoosh 2018-10-19 21:08:47)

big_smile Just to let you know. Firefight is being updated right now!
And @gorav
No problem. I hope it could be in some use. I think i didn't explane enough in the readme. Feel free to ask me in this post if any thing needs explaning

---
Co-founder of Sonorous Arts.
Check out Sonorous Arts on github: https://github.com/sonorous-arts/
my Discord: kianoosh.shakeri2#2988

2018-10-20 04:10:27

Awesome stuff, thumbs up!

2018-10-22 05:40:43 (edited by cartertemm 2018-10-22 05:45:53)

good stuff, I'm sure this will benefit the community. A pretty short code review is as follows. Keep in mind some of these are extremely trivial. The points are in no particular order. Cool project, keep up the good work!


  • Two identical readme.md's, somehow I doubt this was intentional.

  • I notice you were at one time using pygame by the commented out calls and have since switched to pyglet. However, it's still a requirement due to the usage of AGK. I'd personally choose one and only one, as using them side-by-side can get messy and introduce all manner of conflictions. Not to mention python isn't famous for it's slim executibles, so every bit helps to reduce the size. In this case you could save a couple MB's.

  • Whenever possible, try and avoid including easily obtainable modules directly. this is in reference to AGK/pyglet. Create a requirements.txt, you'll be greatly reducing the required clone time that way with the added bonus of not having to constantly push minor changes. If you need to modify a portion of the module, monkeypatching is your friend. Git submodules are another way of doing it.

  • Use the markdown format in your readme. This allows for familiar navigation if viewed from a browser. Otherwise the extension is somewhat misleading. If you'd like to stick with plaintext, change to TXT.

  • use a .gitignore to exclude __pycache__, *.pyc, *.exe, etc.

  • Place the "#" symbol in your comments after indentation as opposed to before it. This helps those navigating based on indentation.

  • Log exceptions

  • Create a license stating what exactly people are, and aren't, allowed to do with your code. The readme touches on that slightly, although I'm not really sure if it passes. Some re-assurance could go a long way. It seems like your cool with people using portions of this code, so the MIT, WTFPL, or a short hand-written you are permitted to use this anywhere no matter what bla bla bla should do just fine.

  • You have your PYC's included in the __pycache__ directory. These can disclose some unwanted info. For example, let's take console.py. I see at time of compiling, you were running 3.6(June 27, 2018). The PYC was generated on 2018-09-23 at 1:48:55 from D:\projects\python\dmnb\python fps.

2018-10-22 07:36:26 (edited by sanslash332 2018-10-22 07:38:08)

thanks for posting something like this!
Python is one of the languajes that i love, so I'm gonna to check the code of hhe game!
thanks for make this stuff!
ps: is so sad see that this thread only have 7 answers.
More people of the development comunnity must be interested in things like that, because works for increase the use of real and powerful languajes like python, and make grow the development comunity

2018-10-22 09:20:40

Congrats for the nice project kianoosh, I wish I knew python lol. The firefight update is very nice, it adds some features that no fps had before such as beeps instead of plain text for the enemy's possition and weapon radar. I'm sad the player base is so low on that game though, I think it deserves more players.

“Get busy living or get busy dying.”
Stephen King

2018-10-22 17:00:17

Thank you guys, specially carter. You probably know i'm really new to git hub so they helped a lot. I try to do all of them you said and Yeah it's exactly what the readme says. Do anything, everywhere with my code. You can credit me "if you like". I didn't make this to ask people thank me. I just did it for people to switch from bgt to python since I really got the pain from bgt myself and i know how bad can things get.

---
Co-founder of Sonorous Arts.
Check out Sonorous Arts on github: https://github.com/sonorous-arts/
my Discord: kianoosh.shakeri2#2988

2018-10-25 17:07:05

i really can't wait to try and test this, great job

best regards
never give up on what ever you are doing.

2018-10-25 17:50:42

why it shows me errors regarding modules although you provided them inthe same foulder.

i always came across this sorts of problems with python and it is being iritating.

Thabks for the nice share anyways.

2018-10-26 01:37:20

what errors Do you get?
Also Added most of the changes carter mentioned, Including the requirements.txt

---
Co-founder of Sonorous Arts.
Check out Sonorous Arts on github: https://github.com/sonorous-arts/
my Discord: kianoosh.shakeri2#2988

2018-10-26 14:26:19

kianoosh wrote:

what errors Do you get?
Also Added most of the changes carter mentioned, Including the requirements.txt



Modules related errors, nothing... Where do i download your firefight game btw? can you tell me the exact download link? couldn't find it yesterday.

2018-10-26 16:13:09

firefight's download link is in the important announcement about firefight topic in the general game discossions room.
And Updated the engine. Now it has a better movement system, A more realistic one which is more similler to mainstream games. Check it out if you like!

---
Co-founder of Sonorous Arts.
Check out Sonorous Arts on github: https://github.com/sonorous-arts/
my Discord: kianoosh.shakeri2#2988

2018-10-26 16:20:47

wow, i like this. this is so cool
just one question: why does there continuisly keep on playing a door loop sound?
when i get close to it, i can't seem to interact with it

best regards
never give up on what ever you are doing.

2018-10-26 16:32:23

That's a random ambience player not an actual door. I put that there to show people how it works.

---
Co-founder of Sonorous Arts.
Check out Sonorous Arts on github: https://github.com/sonorous-arts/
my Discord: kianoosh.shakeri2#2988

2018-10-26 18:07:45

oh, i see. well done

best regards
never give up on what ever you are doing.

2018-10-26 19:24:58

How can I get this in a zip format? I'm not sure how to work the website in order to do this myself.

2018-10-26 21:07:21

Open the page I posted in the first post, press b to find "clone or download", then press space on it. Go down with down arrow until you find the link that says something like "download zip" and of course, open it or copy and paste it into your download manager

---
Co-founder of Sonorous Arts.
Check out Sonorous Arts on github: https://github.com/sonorous-arts/
my Discord: kianoosh.shakeri2#2988

2018-10-27 05:39:41

Kianoosh, what's the clone update command we use to pull the updated repoe?

2018-10-27 13:16:45

Honestly i'm really new to github but I always used git pull. I'm not sure if you have to pull request or not though

---
Co-founder of Sonorous Arts.
Check out Sonorous Arts on github: https://github.com/sonorous-arts/
my Discord: kianoosh.shakeri2#2988

2018-10-30 19:04:59

Hi there. Updated the engine to handle more errors and possibly remove the AL_OUT_OF_MEMORY error. Check out its github page!

---
Co-founder of Sonorous Arts.
Check out Sonorous Arts on github: https://github.com/sonorous-arts/
my Discord: kianoosh.shakeri2#2988

2018-10-30 22:28:43 (edited by alisson 2018-10-30 22:30:18)

hi. Does anyone have the accesible output required to run this project? I tryed to run the game with the accesible output in it main repository but wehn I run the fps.py the cmd show me this error.
Traceback (most recent call last):
  File "C:\Users\alisson\python-fps\fps.py", line 2, in <module>
    import console
  File "C:\Users\alisson\python-fps\console.py", line 1, in <module>
    import globals as g
  File "C:\Users\alisson\python-fps\globals.py", line 16, in <module>
    import movement
  File "C:\Users\alisson\python-fps\movement.py", line 3, in <module>
    import map
  File "C:\Users\alisson\python-fps\map.py", line 7, in <module>
    from AGK.speech import auto
  File "C:\Users\alisson\python-fps\AGK\speech\auto.py", line 2, in <module>
    from accessible_output2 import outputs
  File "C:\Users\alisson\AppData\Local\Programs\Python\Python37\lib\site-packages\accessible_output2-0.12.dev0-py3.7.egg\accessible_output2\__init__.py", line 5, in <module>
    from platform_utils import paths
ModuleNotFoundError: No module named 'platform_utils'

Sorry for my english

2018-10-31 12:03:13

Yaye for continuing to update it!

2018-10-31 13:12:11

at post 23:
Check out carter temm's github page, He has a repo of continuum repossetory. it has things you need in it
https://github.com/cartertemm

---
Co-founder of Sonorous Arts.
Check out Sonorous Arts on github: https://github.com/sonorous-arts/
my Discord: kianoosh.shakeri2#2988